Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call onFocus/onBlur #370

Merged
merged 2 commits into from
Jul 2, 2024
Merged

call onFocus/onBlur #370

merged 2 commits into from
Jul 2, 2024

Conversation

hipstersmoothie
Copy link
Contributor

Noticed the component accepted the props but didn't use them

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-resizable-panels ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 7:55pm

@bvaughn bvaughn merged commit f1ce573 into bvaughn:main Jul 2, 2024
4 of 7 checks passed
@bvaughn
Copy link
Owner

bvaughn commented Jul 2, 2024

Hmm seems like this change broke one of the PanelResizeHandle unit tests. Not sure why yet.

Seems like something about declaring the event property breaks the behavior I was testing...

I don't have much time at the moment to dig into this so for now this is my "solution" 28b8660

@bvaughn
Copy link
Owner

bvaughn commented Jul 2, 2024

Version 2.0.20 just deployed with this change.

@hipstersmoothie
Copy link
Contributor Author

hipstersmoothie commented Jul 3, 2024

Thanks! (and thanks for fixing the test)

@hipstersmoothie hipstersmoothie deleted the call-focus branch July 3, 2024 00:06
@bvaughn
Copy link
Owner

bvaughn commented Jul 3, 2024

Yup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants